search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

`DAO.finaliseProposal` if branch seems unnecessary #234

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

@cmichelio

Vulnerability details

DAO.finaliseProposal: the if (!hasQuorum(proposalID)) seems unnecessary as it's already finalising

0xBrian commented 3 years ago

https://github.com/vetherasset/vaderprotocol-contracts/commit/f7c7085af0eb871ba80db3932acc703fd6d3623c

dmvt commented 3 years ago

duplicate of #186