strictly-scarce
commented
3 years ago Does it cause a loss of funds? Author believes not.
There are other ways to monitor for this, however it would be wise to add an event.
Recommended Severity: 1
Closed code423n4 closed 3 years ago
strictly-scarce
commented
3 years ago Does it cause a loss of funds? Author believes not.
There are other ways to monitor for this, however it would be wise to add an event.
Recommended Severity: 1
dmvt
commented
3 years ago duplicate of #250
Handle
0xRajeev
Vulnerability details
Impact
The flipMinting() function can disable/stop conversion/redeeming of VADER<>USDV tokens upon DAO approval (when that functionality is added). However, this function is missing an event emission for off-chain monitoring tools to monitor this critical on-chain change.
Proof of Concept
https://github.com/code-423n4/2021-04-vader/blob/3041f20c920821b89d01f652867d5207d18c8703/vader-protocol/contracts/Vader.sol#L171-L177
Tools Used
Manual Analysis
Recommended Mitigation Steps
Add a flipMinting event and emit that at the end of flipMinting() function.