code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Variables can be declared constant #248

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

s1m0

Vulnerability details

Impact

Some variables can be declared constant reducing the gas cost. Vader.sol

Proof of Concept

-

Tools Used

Manual analysis

Recommended Mitigation Steps

Make them constant.

0xBrian commented 3 years ago

Most likely addressed in one of https://github.com/vetherasset/vaderprotocol-contracts/commit/66ce8d72bcd91544f5f1b0382d5e809aa6b71a44 https://github.com/vetherasset/vaderprotocol-contracts/commit/2dacdc3716706c8f635e7173b3fc5f1b42869a35

dmvt commented 3 years ago

duplicate of #129