code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Different pragma solidity #25

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

gpersoon

Vulnerability details

Impact

Vault.sol has a different pragma statement than the rest, it contains an additional "^".

For the record the Vether.sol contract (as deployed here https://etherscan.io/address/0x4Ba6dDd7b89ed838FEd25d208D4f644106E34279#code), has a different solidity version.

It's cleaner to use the same versions.

Proof of Concept

DAO.sol:pragma solidity 0.8.3; Factory.sol:pragma solidity 0.8.3; Pools.sol:pragma solidity 0.8.3; Router.sol:pragma solidity 0.8.3; Synth.sol:pragma solidity 0.8.3; USDV.sol:pragma solidity 0.8.3; Utils.sol:pragma solidity 0.8.3; Vader.sol:pragma solidity 0.8.3; Vault.sol:pragma solidity ^0.8.3; Vether.sol:pragma solidity 0.6.4;

Tools Used

Editor

Recommended Mitigation Steps

Use the same solidity versions

strictly-scarce commented 3 years ago

Valid