code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

The flashProof check can be bypassed at the start #259

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

s1m0

Vulnerability details

Impact

The blockDelay variable is not set so at deploy time the flashProof() modifier doesn't work as expected.

Proof of Concept

https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/USDV.sol#L41

Tools Used

Manual analysis

Recommended Mitigation Steps

Set the blockDelay in the init() with a predefined value or through an argument.

dmvt commented 3 years ago

duplicate of #307