Closed code423n4 closed 3 years ago
s1m0
The formula is different from the comment, the impact could be high if the comment was actually rigth.
https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L239 is different from comment on line 234. Should be _units = ((P * (part1 + part2)) / part3) if the comment is rigth.
Manual analysis
Correct the code or the comment.
duplicate of #204
dmvt
commented
3 years ago dmvt
commented
3 years ago
Handle
s1m0
Vulnerability details
Impact
The formula is different from the comment, the impact could be high if the comment was actually rigth.
Proof of Concept
https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L239 is different from comment on line 234. Should be _units = ((P * (part1 + part2)) / part3) if the comment is rigth.
Tools Used
Manual analysis
Recommended Mitigation Steps
Correct the code or the comment.