code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

[INFO] Code style suggestions #285

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

paulius.eth

Vulnerability details

Impact

Not an actual issue, just several observations about the codestyle:

uint private _year = 31536000; could be replaced with: uint private _year = 365 days; to improve readability. Same with: minGrantTime = 2592000; // 30 days

Some require statements have error msgs, some don't. Better would be to unify that. For example, function listAnchor doesn't but function replaceAnchor does.