search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

uint can never be negative #297

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

paulius.eth

Vulnerability details

Impact

Useless checking >= 0 as uint cannot go negative: require((bp <= 10000) && (bp >= 0), "Must be correct BP"); Same here:

if(_fee >= 0 && _fee <= amount){

0xBrian commented 3 years ago

At some point we got rid of the tautological uint >= 0 checks.

dmvt commented 3 years ago

duplicate of #256