search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Function can be simplified #301

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

s1m0

Vulnerability details

Impact

voteProposal can be simplified,

Proof of Concept

https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/DAO.sol#L83

Tools Used

Manual analysis

Recommended Mitigation Steps

if(hasMajority(proposalID) && (isEqual(_type, 'DAO') || isEqual(_type, 'UTILS') || isEqual(_type, 'REWARD'))) check the condition on line 84 in the outer if.