code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Storage variables are never used #305

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

s1m0

Vulnerability details

Impact

Some variables are declared but never used.

Proof of Concept

https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Factory.sol#L10 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Factory.sol#L11 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Router.sol#L48 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Router.sol#L52 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Pools.sol#L22

Tools Used

Manual analysis

Recommended Mitigation Steps

Remove them.

0xBrian commented 3 years ago

We got rid of all those.

dmvt commented 3 years ago

duplicate of #304