Closed code423n4 closed 3 years ago
s1m0
Variables can be declared constant
https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L16 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L17 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L18
Manual analysis
Make them constant. Sorry for the double report, I forgot them in the previous one
Most likely addressed in one of https://github.com/vetherasset/vaderprotocol-contracts/commit/66ce8d72bcd91544f5f1b0382d5e809aa6b71a44 https://github.com/vetherasset/vaderprotocol-contracts/commit/2dacdc3716706c8f635e7173b3fc5f1b42869a35
duplicate of #129
Handle
s1m0
Vulnerability details
Impact
Variables can be declared constant
Proof of Concept
https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L16 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L17 https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/Utils.sol#L18
Tools Used
Manual analysis
Recommended Mitigation Steps
Make them constant. Sorry for the double report, I forgot them in the previous one