code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

flashProof is not effective at the start #307

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

paulius.eth

Vulnerability details

Impact

In contract USDV blockDelay is not initialized and needs to be explicitly set by calling function setParams. Otherwise, it gets a default value of 0 so flashProof is not effective unless the value is set.

Recommended Mitigation Steps

It depends on the intentions, you can initialize it in the constructor (or init function) or maybe this precaution is intended to be turned on later.