Functions can be declared external

[code423n4]

Handle

s1m0

Vulnerability details

Impact

The following functions can be declared external.

Proof of Concept

Vader.sol

• burn VETH Token
• balanceOf
• allowance
• transfer
• approve
• transferFrom
• distribute
• purgeDeployer
• getDaysContributedForEra Router.sol
• getVADERAmount
• getUSDVAmount
• borrow
• repay
• getSystemCollateralm
• getSystemDebt
• getSystemInteresrPaid Synth.sol
• balanceOf
• transfer
• transferFrom
• approve
• transferTo
• burn
• burnFrom DAO.sol
• init
• newGrantProposal
• newAddressProposal
• voteProposal
• cancelProposal
• finaliseProposal Pools.sol
• init
• isMember
• isSynth Factory.sol
• init

Tools Used

Slither

Recommended Mitigation Steps

Declare them external. Use slither in your CI it helps not only for this.

[0xBrian]

Probably addressed in mega external patch, https://github.com/vetherasset/vaderprotocol-contracts/commit/d946b6262ac83cdb7722baa3a8684c4ceabf4ea3

[dmvt]

duplicate of #14