search

code-423n4 / 2021-05-fairside-findings

0 stars 0 forks source link

Wrong error message in `__castOffchainVotes` #36

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Vulnerability Details

The error message states:

require(
    proposal.offchain,
    "FairSideDAO::__castOffchainVotes: proposal is meant to be voted offchain"
);

But it should be "... meant to be voted onchain".

fairside-core commented 3 years ago

The change requested simply changes the text reported to off-chain processes and does not accompany a change in functionality.

fairside-core commented 3 years ago

Fixed in PR#15.

cemozerr commented 3 years ago

Labeling this as non-critical as the issue does not pose any risk to functionality.