search

code-423n4 / 2021-05-fairside-findings

0 stars 0 forks source link

convictionless mapping is not used #61

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

convictionless can be set via function setConvictionless, however, it is not used anywhere across the system, thus making it useless. Based on the comment above this variable, I expect to see it used in functions like _updateConvictionScore.

Recommended Mitigation Steps

Either remove this mapping or use it where intended.

fairside-core commented 3 years ago

Quite strange no one else identified this one! The absence of usage was a merging mistake, this particular mapping is slightly important to the overall operation of FairSide as certain parties should not accrue conviction, such as the Governance wallet. I believe it should be increased to medium level severity.

fairside-core commented 3 years ago

Fixed in PR#10.