code-423n4 / 2021-05-nftx-findings

1 stars 0 forks source link

Using calldata when not appropiate #100

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

a_delamo

Vulnerability details

here more info: https://gist.github.com/alexon1234/7b6799434cccda5e3f3d461b8186ec89

cemozerr commented 3 years ago

@0xKiwi can you explain why you've disputed this issue?

0xKiwi commented 3 years ago

Hello. The functions here are marked as external and do not modify the parameters at all. There is no need for us to place them into memory since that costs more gas.