code-423n4 / 2021-05-nftx-findings

1 stars 0 forks source link

Cannot set the variable `eligibilityManager` in `NFTXVaultFactoryUpgradeable` #107

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

shw

Vulnerability details

Impact

The variable eligibilityManager in the contract NFTXVaultFactoryUpgradeable is not set or used. However, this variable is referenced in the function deployEligibilityStorage of NFTXVaultUpgradeable, which should be initialized.

Proof of Concept

Referenced code: NFTXVaultFactoryUpgradeable.sol#L24 NFTXVaultUpgradeable.sol#L163-L177

Tools Used

None

Recommended Mitigation Steps

Add functions in NFTXVaultFactoryUpgradeable to set the variable eligibilityManager.