code-423n4 / 2021-05-nftx-findings

1 stars 0 forks source link

Unused variables and events in `NFTXMintRequestEligibility` #109

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

shw

Vulnerability details

Impact

In the contract NFTXMintRequestEligibility, the state variable manager is not used. The state variable reverseEligOnRedeem is assigned to a value during initialization but not used afterwards. There are also unused events, CanApproveMintRequestsSet, Reject, and Approve.

Proof of Concept

Referenced code: NFTXMintRequestEligibility.sol#L28 NFTXMintRequestEligibility.sol#L31 NFTXMintRequestEligibility.sol#L44 NFTXMintRequestEligibility.sol#L50-L51

Tools Used

None

Recommended Mitigation Steps

Consider removing these variables and events to save gas.

0xKiwi commented 3 years ago

Implemented usage of the above missing items.

cemozerr commented 3 years ago

Duplicate of https://github.com/code-423n4/2021-05-nftx-findings/issues/63