code-423n4 / 2021-05-visorfinance-findings

0 stars 0 forks source link

Getting NFT could exceed block size limit #64

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

Sherlock

Vulnerability details

Impact

On line 239 it loops over all the NFTs stored in the contract. Although a return statement is included it can cause the transaction to run out of gas in case of an extreme amount of NFTs.

Proof of Concept

N/A

Tools Used

Hardhat

Recommended Mitigation Steps

ghost commented 3 years ago

duplicate https://github.com/code-423n4/2021-05-visorfinance-findings/issues/66

ghoul-sol commented 3 years ago

It’s high severity because of #66