search

code-423n4 / 2021-05-visorfinance-findings

0 stars 0 forks source link

Events are not indexed #70

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

shw

Vulnerability details

Impact

The emitted events are not indexed, making off-chain scripts such as front-ends of dApps difficult to filter the events efficiently.

Proof of Concept

Referenced code: Visor.sol#L95-L100

Tools Used

None

Recommended Mitigation Steps

Add the indexed keyword in each event, e.g., event AddNftToken(address indexed nftContract, uint256 tokenId);.

ghost commented 3 years ago

sponsor acknowledged We will consider indexing events in our next version

ghoul-sol commented 3 years ago

While true, it’s non-critical issue

ztcrypto commented 3 years ago

patch link