code-423n4 / 2021-05-yield-findings

0 stars 0 forks source link

Unlocked Pragma #33

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Contracts should be deployed using the same compiler version/flags with which they have been tested. Locking the floating pragma, i.e. by not using ^ in pragma solidity ^0.8.0, ensures that contracts do not accidentally get deployed using an older compiler version with unfixed bugs.

For reference, see https://swcregistry.io/docs/SWC-103

Recommend removing ^ in pragma solidity ^0.8.0 and change it to pragma solidity 0.8.3 to be consistent with the rest of the contracts.

alcueca commented 3 years ago

Duplicated with #10, thanks for the description of how this would become an issue.

dmvt commented 3 years ago

duplicate of #54