search

code-423n4 / 2021-06-gro-findings

0 stars 1 forks source link

Unused code #71

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

contract LifeGuard3Pool has unused events: LogHealhCheckUpdate, LogNewEmergencyWithdrawal. Interfaces IHarvest and IStake are not used. contract Buoy3Pool has unused variable TIME_LIMIT and a variable that is only initialized but never used: lpToken. Style issue: BASIS_POINTS all caps indicate it should be a constant, however, an owner can change it by calling function setBasisPointsLmit.

Recommended Mitigation Steps

Make use of this code or remove it.

ghoul-sol commented 3 years ago

BASIS_POINTS is a duplicate of #23. It's just part of the described issue so I won't make it a duplicate but in the future it would be better to split "unused code" and "style convention" issues. Otherwise, I have to make a subjective judgement to degrade the issue to a duplicate or not.