search

code-423n4 / 2021-06-gro-findings

0 stars 1 forks source link

updateStrategiesDebtRatio function and LogNewDebtRatios event #74

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

function updateStrategyRatio calls updateStrategiesDebtRatio and emits LogNewDebtRatios event. function invest also calls updateStrategiesDebtRatio but does not emit this event.

Recommended Mitigation Steps

You can extract this coupled functionality to a separate function to make sure that LogNewDebtRatios is always emitted when updateStrategiesDebtRatio is called.

kitty-the-kat commented 3 years ago

this event should be removed, as another one is emitted in the underlying vault