code-423n4 / 2021-06-gro-findings

0 stars 1 forks source link

Inconsistent Usage of CONSTANT naming in Buoy3Pool #85

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

GalloDaSballo

Vulnerability details

Impact

Detailed description of the impact of this finding.

In Buoy3Pool.sol: https://github.com/code-423n4/2021-06-gro/blob/091660467fc8d13741f8aafcec80f1e8cf129a33/contracts/pools/oracle/Buoy3Pool.sol#L30

The variables

    uint256 TIME_LIMIT = 3000;
    uint256 public BASIS_POINTS = 20;

Are not constants However, CHAIN_FACTOR is

    uint256 constant CHAIN_FACTOR = 100;

While there is no vulnerability, I highly recommend sticking to the convention of using all caps for constants

ghoul-sol commented 3 years ago

Duplicate of #23