code-423n4 / 2021-06-gro-findings

0 stars 1 forks source link

totalAssets > withdrawUsd should be inclusive #86

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

The check should be inclusive here to cover the case when totalAssets = withdrawalUsd: require(totalAssets > withdrawUsd, "totalAssets < withdrawalUsd");

Recommended Mitigation Steps

require(totalAssets >= withdrawUsd, "totalAssets < withdrawalUsd");

kitty-the-kat commented 3 years ago

Unsure what part is being referenced

kitty-the-kat commented 3 years ago

Edge case that is unlikely to cause issues as gro protocol provides initial seed investment