code-423n4 / 2021-06-gro-findings

0 stars 1 forks source link

RebasingGToken emits same events on transfer #91

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Vulnerability Details

The RebasingGToken.transfer function logs LogTransfer(msg.sender, recipient, amount) but the previous super._transfer call already logs the exact same arguments Transfer(sender, recipient, amount).

Recommended Mitigation Steps

The LogTransfer event is not needed for the rebasing token as it is the same as the Transfer event of the base class. Removing and not emitting LogTransfer saves gas on every transfer.