search

code-423n4 / 2021-06-pooltogether-findings

0 stars 0 forks source link

No event emitted in `compLikeDelegate` function #117

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

shw

Vulnerability details

Impact

The compLikeDelegate function of PrizePool does not emit an event after the votes of the PrizePool are delegated to someone.

Proof of Concept

Referenced code: PrizePool.sol#L1048-L1052

Recommended Mitigation Steps

Emit an event after line 1050 if this function is considered important.

asselstine commented 3 years ago

We can listen to the delegate event of the underlying COMP-like token.

dmvt commented 3 years ago

Per sponsor, there is an event. Closing.