code-423n4 / 2021-06-pooltogether-findings

0 stars 0 forks source link

User could lose underlying tokens when redeeming from the `IdleYieldSource` #121

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

shw

Vulnerability details

Impact

This submission is to clarify that the previous submission is invalid

Proof of Concept

At line 131 of IdleYieldSource, the use of the variable redeemedShare is correct since the input parameter of redeemIdleToken should be the amount of IdleTokens instead of underlying tokens (as mentioned in Idle Finance's documentation).

Referenced code: IdleYieldSource.sol#L129-L131 Idle Finance documentation - redeemIdleToken

Recommended Mitigation Steps

None

asselstine commented 3 years ago

See https://github.com/code-423n4/2021-06-pooltogether-findings/issues/120

dmvt commented 3 years ago

duplicate of #120