code-423n4 / 2021-06-pooltogether-findings

0 stars 0 forks source link

CreditBurned event emitted even on zero tokens burned #97

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

In PrizePool._updateCreditBalance the CreditBurned event is emitted even if nothing was burned. Not emitting this event when nothing happened can save gas and also seems better semantically.

aodhgan commented 3 years ago

https://github.com/pooltogether/pooltogether-pool-contracts/pull/302