search

code-423n4 / 2021-06-tracer-findings

1 stars 0 forks source link

amountToReturn > receipt.escrowedAmount could be inclusive #108

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Could save some gas here when amountToReturn = receipt.escrowedAmount: if (amountToReturn > receipt.escrowedAmount) { liquidationReceipts[receiptId].escrowedAmount = 0; } else { liquidationReceipts[receiptId].escrowedAmount = receipt.escrowedAmount - amountToReturn; }

Recommended Mitigation Steps

if (amountToReturn >= receipt.escrowedAmount) { ...