Open code423n4 opened 3 years ago
0xsanson
In the trader contract isValidSignature(...) and verifySignature(...) serve the same purpose. Suggested keep only one for code clarity.
https://github.com/code-423n4/2021-06-tracer/blob/main/src/contracts/Trader.sol#L206 https://github.com/code-423n4/2021-06-tracer/blob/main/src/contracts/Trader.sol#L231
Manual analysys
Suggested keep only one function for code clarity.
Handle
0xsanson
Vulnerability details
Impact
In the trader contract isValidSignature(...) and verifySignature(...) serve the same purpose. Suggested keep only one for code clarity.
Proof of Concept
https://github.com/code-423n4/2021-06-tracer/blob/main/src/contracts/Trader.sol#L206 https://github.com/code-423n4/2021-06-tracer/blob/main/src/contracts/Trader.sol#L231
Tools Used
Manual analysys
Recommended Mitigation Steps
Suggested keep only one function for code clarity.