search

code-423n4 / 2021-06-tracer-findings

1 stars 0 forks source link

releaseTime different from whitepaper #27

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

gpersoon

Vulnerability details

Impact

The whitepaper document a liquidator can claim slippage reimbursement within 10 minutes. However in the code releaseTime is set to 15 minutes.

Proof of Concept

// https://tracer.finance/media/whitepapers/perp-swaps/Tracer_Perpetual_Swaps.pdf "the allowed time to claim slippage reimbursement (~10 minutes),"

// https://github.com/code-423n4/2021-06-tracer/blob/main/src/contracts/Liquidation.sol#L26 uint256 public override releaseTime = 15 minutes;

Tools Used

Recommended Mitigation Steps

Assuming 15 minutes it the preferred period, add a comment that this is different than the white paper + reason why it is different.

raymogg commented 3 years ago

It was decided that the release time can be dynamically changed depending on what each market needs. While the current set release time in the contracts does differ from the whitepaper, it can also be changed at any time.

Not really an issue, but we will update our documentation to make this more clear.

cemozerr commented 3 years ago

Marking this as invalid as this is not an issue.