In supplyTokenTo, redeemToken, approveMaxAmount, _setYieldSource, and _transferFunds you write:
_yieldSource.depositToken(), however you already defined a public function called depositToken to retrieve the address of the depositToken for the current Yield Source.
Since it's marked public, you could refactor every use of _yieldSource.depositToken() to depositToken()
Otherwise, you can mark the function as external so that it's clear it's just supposed to be used from outside
PierrickGT
commented
3 years ago
Handle
GalloDaSballo
Vulnerability details
Impact
In
supplyTokenTo,redeemToken,approveMaxAmount,_setYieldSource, and_transferFundsyou write:_yieldSource.depositToken(), however you already defined apublicfunction calleddepositTokento retrieve the address of the depositToken for the current Yield Source.Since it's marked public, you could refactor every use of
_yieldSource.depositToken()todepositToken()Otherwise, you can mark the function as
externalso that it's clear it's just supposed to be used from outside