code-423n4 / 2021-07-pooltogether-findings

0 stars 0 forks source link

Inverted isInvalidYieldSource #77

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

isInvalidYieldSource in function _requireYieldSource actually has a reverted meaning, when it is true, the source is treated as valid: require(isInvalidYieldSource, "SwappableYieldSource/invalid-yield-source"); Rename it to isValidYieldSource.

PierrickGT commented 3 years ago

Duplicate of https://github.com/code-423n4/2021-07-pooltogether-findings/issues/8