code-423n4 / 2021-07-sherlock-findings

0 stars 0 forks source link

ERC20 non-standard names #117

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Usually, the functions to increase the allowance are called increaseAllowance and decreaseAllowance but in SherXERC20 they are called increaseApproval and decreaseApproval

Recommendation

Rename these functions to the more common names.

Evert0x commented 3 years ago

Good point https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#ERC20

Evert0x commented 3 years ago

0 non-critical

ghoul-sol commented 3 years ago

I agree with warden, low risk looks reasonable here.