search

code-423n4 / 2021-07-sherlock-findings

0 stars 0 forks source link

Poorly Named variables #123

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

tensors

Vulnerability details

Impact

Poorly named variables in Gov.sol

Proof of Concept

_protocolPremium is a bool while protcolPremium is a mapping to uint. This is confusing a could potentially cause some input errors.

Recommended Mitigation Steps

Rename variables.

Evert0x commented 3 years ago

Will change the _protocolPremium bool to _isProtocolPremium

Evert0x commented 3 years ago

Severity is 0 non critical

ghoul-sol commented 3 years ago

yes, this is non-critical