The transferFrom function of SherXERC20 checks the _from address to be non-zero, while the _to address is not checked. Neither the _from address nor the _to address is checked for the' transfer' function.
Consider adding non-zero address checks for the _from and _to addresses in the internal _transfer function instead of the transfer or transferFrom functions.
Evert0x
commented
3 years ago
Handle
shw
Vulnerability details
Impact
The
transferFromfunction ofSherXERC20checks the_fromaddress to be non-zero, while the_toaddress is not checked. Neither the_fromaddress nor the_toaddress is checked for the' transfer' function.Proof of Concept
Referenced code: SherXERC20.sol#L105 SherXERC20.sol#L94-L97
Recommended Mitigation Steps
Consider adding non-zero address checks for the
_fromand_toaddresses in the internal_transferfunction instead of thetransferortransferFromfunctions.