Open code423n4 opened 3 years ago
shw
Adding non-zero address checks on the following function's parameters can help ensure the ownership of contracts is not lost or the contracts do not need to be redeployed if any of them is provided as zero accidentally.
Referenced code: GovDev.sol#L19-L23 NativeLock.sol#L19 ForeignLock.sol#L20
Consider adding non-zero address checks on the parameters.
GovDev.sol#L19-L23 is used to eventually renounce the role, but maybe it makes sense to create a different function for that.
GovDev.sol#L19-L23
Handle
shw
Vulnerability details
Impact
Adding non-zero address checks on the following function's parameters can help ensure the ownership of contracts is not lost or the contracts do not need to be redeployed if any of them is provided as zero accidentally.
Proof of Concept
Referenced code: GovDev.sol#L19-L23 NativeLock.sol#L19 ForeignLock.sol#L20
Recommended Mitigation Steps
Consider adding non-zero address checks on the parameters.