search

code-423n4 / 2021-07-sherlock-findings

0 stars 0 forks source link

Approval event in LibSherXERC20 #67

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Library LibSherXERC20 declares and emits Transfer event so I also expected to see the Approval event emitted in function approve.

Recommended Mitigation Steps

Declare and emit Approval(_from, _to, _amount);

Evert0x commented 3 years ago

The library function is called one, an approval event is submitted there https://github.com/code-423n4/2021-07-sherlock/blob/main/contracts/facets/SherXERC20.sol#L90

ghoul-sol commented 3 years ago

per sponsor comment, invalid