search

code-423n4 / 2021-07-sherlock-findings

0 stars 0 forks source link

Call to LibDiamond.contractOwner() can be cached #73

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Call to LibDiamond.contractOwner() can be cached here: require(msg.sender == LibDiamond.contractOwner(), 'NOT_DEV'); require(_govDev != LibDiamond.contractOwner(), 'SAME_DEV');

Recommended Mitigation Steps

address contractOwner = LibDiamond.contractOwner();
require(msg.sender == contractOwner , 'NOT_DEV');
require(_govDev != contractOwner, 'SAME_DEV');