code-423n4 / 2021-07-spartan-findings

0 stars 0 forks source link

Missing onlyPool modifier on burnSynth #165

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Vulnerability Details

The Synth.burnSynth function can be called by anyone but it should only be called from a pool, like mintSynth.

Impact

An attacker can attempt to burn tokens in the synth contract, but it should fail as the LP debt / balance is always zero for non-pools.

Recommended Mitigation Steps

Add the onlyPool modifier to burnSynth.

SamusElderg commented 3 years ago

Duplicate of #70