Open code423n4 opened 3 years ago
0xsanson
In synthFactory.sol, there's an event CreateSynth(address indexed token, address indexed pool). However the event is emitted with "synth" as second output.
event CreateSynth(address indexed token, address indexed pool)
https://github.com/code-423n4/2021-07-spartan/blob/main/contracts/synthFactory.sol#L13 https://github.com/code-423n4/2021-07-spartan/blob/main/contracts/synthFactory.sol#L46
editor
Think about what's the better variable to be emitted, and correct one of the lines.
Code can be a little bit more cleaner
Handle
0xsanson
Vulnerability details
Impact
In synthFactory.sol, there's an
event CreateSynth(address indexed token, address indexed pool)
. However the event is emitted with "synth" as second output.Proof of Concept
https://github.com/code-423n4/2021-07-spartan/blob/main/contracts/synthFactory.sol#L13 https://github.com/code-423n4/2021-07-spartan/blob/main/contracts/synthFactory.sol#L46
Tools Used
editor
Recommended Mitigation Steps
Think about what's the better variable to be emitted, and correct one of the lines.