search

code-423n4 / 2021-07-spartan-findings

0 stars 0 forks source link

No checking of recipient address validation during low-level call #212

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

JMukesh

Vulnerability details

Impact

funds can be lost

Proof of Concept

https://github.com/code-423n4/2021-07-spartan/blob/e2555aab44d9760fdd640df9095b7235b70f035e/contracts/Router.sol#L214

Tools Used

manual review

Recommended Mitigation Steps

check recipient address before sending bnb

ghoul-sol commented 3 years ago

This is best practices, non-critical.

ghoul-sol commented 3 years ago

On second thought, burning by sending to address(0) is a valid use case.