search

code-423n4 / 2021-07-spartan-findings

0 stars 0 forks source link

Lack of emission of event when changing dao fees #215

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

JMukesh

Vulnerability details

Impact

event should be emitted after the sensitive action like updating fees, to track off-chain changes

Proof of Concept

https://github.com/code-423n4/2021-07-spartan/blob/e2555aab44d9760fdd640df9095b7235b70f035e/contracts/Dao.sol#L128

Tools Used

manual review

Recommended Mitigation Steps

Emit an event for critical parameter changes.

verifyfirst commented 3 years ago

Genesis factors are intended to be called only once - we consider events to be used on regular actions.