Open code423n4 opened 3 years ago
JMukesh
event should be emitted after the sensitive action like updating fees, to track off-chain changes
https://github.com/code-423n4/2021-07-spartan/blob/e2555aab44d9760fdd640df9095b7235b70f035e/contracts/Dao.sol#L128
manual review
Emit an event for critical parameter changes.
Genesis factors are intended to be called only once - we consider events to be used on regular actions.
Handle
JMukesh
Vulnerability details
Impact
event should be emitted after the sensitive action like updating fees, to track off-chain changes
Proof of Concept
https://github.com/code-423n4/2021-07-spartan/blob/e2555aab44d9760fdd640df9095b7235b70f035e/contracts/Dao.sol#L128
Tools Used
manual review
Recommended Mitigation Steps
Emit an event for critical parameter changes.