search

code-423n4 / 2021-07-spartan-findings

0 stars 0 forks source link

Missing synthReward #221

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

0xsanson

Vulnerability details

Impact

In synthVault.sol, the function _processWithdraw() has a variable synthReward (in the return) that is never initialized.

Proof of Concept

https://github.com/code-423n4/2021-07-spartan/blob/main/contracts/synthVault.sol#L191

Tools Used

editor

Recommended Mitigation Steps

Consider the role of this variable and define it accordingly.

SamusElderg commented 3 years ago

Duplicate of #168 (Partial; obviously this issue deserves a much smaller share as its the non-critical part)

ghoul-sol commented 3 years ago

Not enough evidence in description to support high risk. Making this non-cirtical.