code-423n4 / 2021-07-wildcredit-findings

0 stars 0 forks source link

Unimplemented methods in several interfaces #140

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

shw

Vulnerability details

Impact

Some methods declared in the interfaces are not implemented. Specifically, the withdrawRepay method of ILendingPair and the liqFeePool method of Controller.

Proof of Concept

Referenced code: IController.sol#L14 ILendingPair.sol#L22

Recommended Mitigation Steps

Remove the unimplemented methods.

talegift commented 3 years ago

Risk should be lowered to 0.

ghoul-sol commented 3 years ago

No exploit here, non-critical