code-423n4 / 2021-08-floatcapital-findings

0 stars 0 forks source link

Index Events #55

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

hickuphh3

Vulnerability details

Impact

It would be beneficial to index certain arguments in events (eg. marketIndex and user in LongShort.sol), For example, it would be easy to filter through event emissions (using web3js / ethersjs / polygonscan APIs), and for the creation of subgraphs.

JasoonS commented 3 years ago

Thanks. This uses more gas and doesn't provide benefit to subgraphs (which is what we are using - maybe a bit too much vendor lock-in :see_no_evil:).

We will consider this however.