`Vec::new()` instead of `Iterator::collect()`

[code423n4]

Handle

nascent

Vulnerability details

[I-01] Vec::new() instead of Iterator::collect()

Severity: Low

Ex: fn encode_logic_call_confirm() in message_signatures.rs

 fn foo(vals: &[Bar]) -> Vec<Bar> {
    let mut new_array = Vec::new();
    for val in vals.iter() {
        new_array.push(val.clone())
    }
    new_array
}

Recommendation

To avoid mutability and instantiating/resizing a Vec, .collect() an Iterator into an immutable Vec directly:

 fn foo(vals: &[Bar]) -> Vec<Bar> {
     vals.iter().cloned().collect()
 }

[jkilpatr]

This is a good suggestion and moderately more efficient.

[loudoguno]

reopening as per judges assessment as "primary issue" on findings sheet