code-423n4 / 2021-08-gravitybridge-findings

1 stars 0 forks source link

Misleading comments in nonce fetching functions #57

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/althea-net/cosmos-gravity-bridge/blob/main/orchestrator/ethereum_gravity/src/utils.rs#L93

https://github.com/althea-net/cosmos-gravity-bridge/blob/main/orchestrator/ethereum_gravity/src/utils.rs#L119

https://github.com/althea-net/cosmos-gravity-bridge/blob/main/orchestrator/ethereum_gravity/src/utils.rs#L149

These comments are excatly same (probably due to copy paste) and misleading as the following functions fetch different kind of nonces.

Marking low risk as per https://docs.code4rena.com/roles/wardens/judging-criteria#estimating-risk-tl-dr

jkilpatr commented 3 years ago

very straightforward, can't argue with the rubric I guess.

albertchon commented 3 years ago

Haha indeed 😅