code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

lack of zero address validation in constructor #51

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

JMukesh

Vulnerability details

Impact

since the parameter of the constructor are used to initialize the sate variable and these state variable are used throughout the contract error in these parameter can lead to redeployment of the contract

Proof of Concept

constructor of ctokenAggregator.sol, NotionalV1ToNotionalV2.sol, nTokenERC20Proxy.sol, Reservoir.sol, PauseRouter.sol lack zero address validation

Tools Used

manual review

Recommended Mitigation Steps

add address(0) validation in constructor

jeffywu commented 3 years ago

Duplicate of #93